EDGJNSCR in SYS1.SAMPLIB changes required

There are several errors in the EDGJNSCR samplib member. We ship several sample reporting jobs in SYS1.SAMPLIB, that are based on non-extended records but the job itself is does not specify this in its description. We should update the sample job to indicate it will only work with non-extended EXTRACT records as coded. We should either ship a version that works for extended Extract records or add something to the effect that if you are using extended extract records you need to make the following change in the JCL to get the job to work:

//VOLSCNTL DD * DFSORT STATEMENTS - SELECT SCRATCH VOLUMES
INCLUDE COND=(5,1,CH,EQ,C'X',AND,322,7,CH,EQ,C'SCRATCH')
OPTION VLSHRT,NOCHALT,LOCALE=NONE @03C
//OLDSCNTL DD * DFSORT STATEMENTS - SELECT SCRATCH VOLUMES
INCLUDE COND=(5,1,CH,EQ,C'X',AND,322,7,CH,EQ,C'SCRATCH')
OPTION VLSHRT,NOCHALT,LOCALE=NONE @03C


Furthermore, the job assumes DFSORT is the SORT product and invokes a parm only DFSORT uses, so we might also want to mention that if using other than DFSORT you may need to change the VLSHRT parm. This parameter does NOT apply for SYNCSORT as they have their own parms to handle short variable records. It is called VLTESTI (handling INCLUDE/OMIT). The parm has an capital i at the end which might look like 1. So for Syncsort users they will need to change VLSHRT to VLTESTI=1 or VLTESTI=2 in the ddnames VOLSCNTL and OLDSCNTL.

Furthermore, in this JCL there is a referback statment. It would be best to avoid concatenation with referback due to the potential problems caused by the system restriction described here in the second bullet:
"Be aware that, in some cases, if a DD statement specifies a data set for output that is extended to a second or subsequent volume, and another DD statement within the same step requests the same data set, only the records on the first volume will be read, and incorrect output will result."